[
https://issues.apache.org/jira/browse/BEAM-10940?focusedWorklogId=502709&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-502709
]
ASF GitHub Bot logged work on BEAM-10940:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Oct/20 14:07
Start Date: 20/Oct/20 14:07
Worklog Time Spent: 10m
Work Description: mxm commented on a change in pull request #13120:
URL: https://github.com/apache/beam/pull/13120#discussion_r508538663
##########
File path:
runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/control/ProcessBundleDescriptors.java
##########
@@ -141,9 +139,7 @@ private static ExecutableProcessBundleDescriptor
fromExecutableStageInternal(
Map<String, Map<String, TimerSpec>> timerSpecs = forTimerSpecs(stage,
components);
- if (bagUserStateSpecs.size() > 0 || timerSpecs.size() > 0) {
- lengthPrefixKeyCoder(stage.getInputPCollection().getId(), components);
- }
+ lengthPrefixAnyInputCoder(stage.getInputPCollection().getId(), components);
Review comment:
My bad, the length prefixing here only applies to the coder in the
ProcessBundleDescriptor. Indeed, any buffering won't be affected by this
because the elements have already been decoded when they are buffered.
For the test case, FlinkSavepointITCase should verify that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 502709)
Time Spent: 1h 10m (was: 1h)
> Portable Flink runner should handle DelayedBundleApplication from
> ProcessBundleResponse.
> ----------------------------------------------------------------------------------------
>
> Key: BEAM-10940
> URL: https://issues.apache.org/jira/browse/BEAM-10940
> Project: Beam
> Issue Type: New Feature
> Components: runner-flink
> Reporter: Boyuan Zhang
> Priority: P2
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> SDF can produce residuals by self-checkpoint, which will be returned to
> runner by ProcessBundleResponse.DelayedBundleApplication. The portable runner
> should be able to handle the DelayedBundleApplication and reschedule it based
> on the timestamp.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
