[
https://issues.apache.org/jira/browse/BEAM-6513?focusedWorklogId=191246&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-191246
]
ASF GitHub Bot logged work on BEAM-6513:
----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Jan/19 20:20
Start Date: 28/Jan/19 20:20
Worklog Time Spent: 10m
Work Description: amaliujia commented on pull request #7636: [BEAM-6513]
Fix NPE in BeamEnumerableConverter
URL: https://github.com/apache/beam/pull/7636#discussion_r251576415
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamEnumerableConverter.java
##########
@@ -368,3 +387,7 @@ public void visitValue(PValue value, Node producer) {
return visitor.boundedness == IsBounded.UNBOUNDED;
}
}
+
+class ClassForNull {
Review comment:
I don't want to use synchronization in ParDo is because that's anti pattern.
Using ParDo means we do something in parallel, and synchronization in this
problem means I will essentially make `processElement` run like in a single
thread mode. Also, it is not clear to me at all that how to make
synchronization cross bundles, and clearly synchronization makes too much
assumptions on direct runner. For example, can I assume a lock can be acquired
cross bundle? This becomes more complicated at this moment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 191246)
Time Spent: 1h 40m (was: 1.5h)
> BeamEnumerableConverter doest not handle Null during collecting values
> ----------------------------------------------------------------------
>
> Key: BEAM-6513
> URL: https://issues.apache.org/jira/browse/BEAM-6513
> Project: Beam
> Issue Type: Bug
> Components: dsl-sql
> Reporter: Rui Wang
> Assignee: Rui Wang
> Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
