[
https://issues.apache.org/jira/browse/BEAM-9547?focusedWorklogId=505885&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-505885
]
ASF GitHub Bot logged work on BEAM-9547:
----------------------------------------
Author: ASF GitHub Bot
Created on: 28/Oct/20 19:37
Start Date: 28/Oct/20 19:37
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on a change in pull request
#13139:
URL: https://github.com/apache/beam/pull/13139#discussion_r513711027
##########
File path: sdks/python/apache_beam/dataframe/frames.py
##########
@@ -1513,6 +1584,8 @@ def repeat(self, repeats):
'repeat',
lambda series: series.str.repeat(repeats),
[self._expr],
+ # Output will also be a str Series
Review comment:
Yeah when I added the verification of the proxy in `TransformTest` I
found that this proxy was incorrectly inferred as `bool` for the zipping case
tested there.
```py
In [10]: proxy.dtypes
Out[10]:
str object
repeats int64
dtype: object
In [11]: proxy.str.str.repeat(proxy.repeats)
Out[11]: Series([], Name: str, dtype: bool)
```
The actual operation does produce `object` though:
```py
In [13]: df.str.str.repeat(df.repeats)
Out[13]:
0 AAA
1 B
2 CCCC
3 DDDDD
4 EE
Name: str, dtype: object
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 505885)
Time Spent: 29h 20m (was: 29h 10m)
> Implement all pandas operations (or raise WontImplementError)
> -------------------------------------------------------------
>
> Key: BEAM-9547
> URL: https://issues.apache.org/jira/browse/BEAM-9547
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: Brian Hulette
> Assignee: Robert Bradshaw
> Priority: P2
> Time Spent: 29h 20m
> Remaining Estimate: 0h
>
> We should have an implementation for every DataFrame, Series, and GroupBy
> method. Everything that's not actually implemented should get a default
> implementation that raises WontImplementError
> See https://github.com/apache/beam/pull/10757#discussion_r389132292
> Progress at the individual operation level is tracked in a
> [spreadsheet|https://docs.google.com/spreadsheets/d/1hHAaJ0n0k2tw465ORs5tfdy4Lg0DnGWIQ53cLjAhel0/edit],
> consider requesting edit access if you'd like to help out.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
