[
https://issues.apache.org/jira/browse/BEAM-4775?focusedWorklogId=191808&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-191808
]
ASF GitHub Bot logged work on BEAM-4775:
----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Jan/19 17:05
Start Date: 29/Jan/19 17:05
Worklog Time Spent: 10m
Work Description: ryan-williams commented on pull request #7641: [DO NOT
MERGE] [BEAM-4775] Portable metrics over the job-server API
URL: https://github.com/apache/beam/pull/7641#discussion_r251896650
##########
File path: model/pipeline/src/main/proto/beam_pipeline_metrics.proto
##########
@@ -0,0 +1,103 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+/*
+ * Protocol Buffers describing the Runner API, which is the runner-independent,
+ * SDK-independent definition of the Beam model.
+ */
+
+syntax = "proto3";
+
+package org.apache.beam.model.pipeline.v1;
+
+option go_package = "pipeline_v1";
+option java_package = "org.apache.beam.model.pipeline.v1";
+option java_outer_classname = "PipelineMetrics";
+
+message MetricKey {
+ string step = 1;
Review comment:
This `MetricKey` and `MetricName` mimic classes in
[Java](https://github.com/apache/beam/blob/efb83e6c2fe486793947f6a80bec3a61f53a06bb/runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/metrics/MetricKey.java)
and
[Python](https://github.com/apache/beam/blob/efb83e6c2fe486793947f6a80bec3a61f53a06bb/sdks/python/apache_beam/metrics/execution.py#L48),
and represent them over the wire.
TODO: use these to replace the SDK-specific classes?
@ajamato's new scheme (in #7624) identifies PCollection-scoped metrics by a
`null` "step" value.
TODO: should they be abandoned over the wire (and in SDKs?) in favor of URNs?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 191808)
Time Spent: 2h 50m (was: 2h 40m)
> JobService should support returning metrics
> -------------------------------------------
>
> Key: BEAM-4775
> URL: https://issues.apache.org/jira/browse/BEAM-4775
> Project: Beam
> Issue Type: Bug
> Components: beam-model
> Reporter: Eugene Kirpichov
> Assignee: Ryan Williams
> Priority: Major
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> [https://github.com/apache/beam/blob/master/model/job-management/src/main/proto/beam_job_api.proto]
> currently doesn't appear to have a way for JobService to return metrics to a
> user, even though
> [https://github.com/apache/beam/blob/master/model/fn-execution/src/main/proto/beam_fn_api.proto]
> includes support for reporting SDK metrics to the runner harness.
>
> Metrics are apparently necessary to run any ValidatesRunner tests because
> PAssert needs to validate that the assertions succeeded. However, this
> statement should be double-checked: perhaps it's possible to somehow work
> with PAssert without metrics support.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
