[
https://issues.apache.org/jira/browse/BEAM-8106?focusedWorklogId=509923&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-509923
]
ASF GitHub Bot logged work on BEAM-8106:
----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Nov/20 20:46
Start Date: 10/Nov/20 20:46
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on a change in pull request
#13211:
URL: https://github.com/apache/beam/pull/13211#discussion_r520854059
##########
File path: sdks/java/container/build.gradle
##########
@@ -86,51 +76,21 @@ licenseReport {
renderers = [new JsonReportRenderer()]
}
-def imageJavaVersion = project.hasProperty('imageJavaVersion') ?
project.findProperty('imageJavaVersion') : '8'
-docker {
- name containerImageName(
- name:
"${project.docker_image_default_repo_prefix}java${imageJavaVersion}_sdk",
- root: project.rootProject.hasProperty(["docker-repository-root"]) ?
- project.rootProject["docker-repository-root"] :
- project.docker_image_default_repo_root,
- tag: project.rootProject.hasProperty(["docker-tag"]) ?
- project.rootProject["docker-tag"] : project.sdk_version)
- dockerfile project.file("./Dockerfile")
- files "./build/"
- buildArgs([
- 'pull_licenses': project.rootProject.hasProperty(["docker-pull-licenses"])
||
- project.rootProject.hasProperty(["isRelease"]),
- 'java_version': imageJavaVersion,
- ])
+task buildAll {
+ dependsOn ':sdks:java:container:java8:docker'
+ dependsOn ':sdks:java:container:java11:docker'
}
task pullLicenses(type: Exec) {
+ dependsOn generateLicenseReport
+ generateLicenseReport.outputs.cacheIf { false }
Review comment:
(not a blocker for this PR) @kennknowles can you comment on why we need
this? It would be good to have a comment explaining it. Looks like it was added
in
https://github.com/apache/beam/commit/ebd65e5314eb42131eace3be62390b3570e71292
##########
File path: runners/portability/java/build.gradle
##########
@@ -214,7 +214,7 @@ def createUlrValidatesRunnerTask = { name, environmentType
->
}
if (environmentType == "DOCKER") {
- vrTask.dependsOn ":sdks:java:container:docker"
+ vrTask.dependsOn ":sdks:java:container:java8:docker"
Review comment:
Are there plans to make this and the other portable tests runnable with
the Java 11 container? Seems like we should drop a TODO and/or file a jira
##########
File path: sdks/java/container/build.gradle
##########
@@ -86,51 +76,21 @@ licenseReport {
renderers = [new JsonReportRenderer()]
}
-def imageJavaVersion = project.hasProperty('imageJavaVersion') ?
project.findProperty('imageJavaVersion') : '8'
-docker {
Review comment:
Maybe we should keep the `:sdks:java:container:docker` task for a bit
and just have it error with a message directing people to java8:docker and/or
java11:docker?
##########
File path: sdks/java/container/build.gradle
##########
@@ -54,17 +55,6 @@ dependencies {
dockerDependency library.java.kafka_clients
}
-task copyDockerfileDependencies(type: Copy) {
Review comment:
Ack, thank you
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 509923)
Time Spent: 14h 20m (was: 14h 10m)
> Publish Java 11 SDK Harness docker image
> ----------------------------------------
>
> Key: BEAM-8106
> URL: https://issues.apache.org/jira/browse/BEAM-8106
> Project: Beam
> Issue Type: Sub-task
> Components: build-system, sdk-java-harness
> Reporter: Hannah Jiang
> Priority: P3
> Labels: Clarified, portability
> Time Spent: 14h 20m
> Remaining Estimate: 0h
>
> There are multiple benefits including optimized String representation in
> memory, better GC, more Docker friendliness and others that could be of the
> interest of users.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
