[
https://issues.apache.org/jira/browse/BEAM-10940?focusedWorklogId=510164&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-510164
]
ASF GitHub Bot logged work on BEAM-10940:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Nov/20 10:13
Start Date: 11/Nov/20 10:13
Worklog Time Spent: 10m
Work Description: mxm commented on a change in pull request #13105:
URL: https://github.com/apache/beam/pull/13105#discussion_r521252916
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/ExecutableStageDoFnOperator.java
##########
@@ -502,6 +690,8 @@ public void close() throws Exception {
processWatermark1(Watermark.MAX_WATERMARK);
while (getCurrentOutputWatermark() <
Watermark.MAX_WATERMARK.getTimestamp()) {
invokeFinishBundle();
+ // Sleep for 5s to wait for any timer to be fired.
+ Thread.sleep(5000);
Review comment:
What you describe happens when you enable checkpointing or when you pass
in `--shutdownSourcesAfterIdleMs`. The operator doesn't shutdown then and
continues to process timers. The reason we do not enable this by default is
that we want to cleanly shutdown pipelines during tests. Once an operator has
been shut down, the entire job cannot be checkpointed anymore.
The new workaround looks good to me. We do the same in the
`super.close()`method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 510164)
Time Spent: 12h 50m (was: 12h 40m)
> Portable Flink runner should handle DelayedBundleApplication from
> ProcessBundleResponse.
> ----------------------------------------------------------------------------------------
>
> Key: BEAM-10940
> URL: https://issues.apache.org/jira/browse/BEAM-10940
> Project: Beam
> Issue Type: New Feature
> Components: runner-flink
> Reporter: Boyuan Zhang
> Assignee: Boyuan Zhang
> Priority: P2
> Time Spent: 12h 50m
> Remaining Estimate: 0h
>
> SDF can produce residuals by self-checkpoint, which will be returned to
> runner by ProcessBundleResponse.DelayedBundleApplication. The portable runner
> should be able to handle the DelayedBundleApplication and reschedule it based
> on the timestamp.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
