[
https://issues.apache.org/jira/browse/BEAM-11142?focusedWorklogId=510433&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-510433
]
ASF GitHub Bot logged work on BEAM-11142:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Nov/20 20:26
Start Date: 11/Nov/20 20:26
Worklog Time Spent: 10m
Work Description: chamikaramj commented on a change in pull request
#13283:
URL: https://github.com/apache/beam/pull/13283#discussion_r521618026
##########
File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner.py
##########
@@ -542,19 +593,32 @@ def run_pipeline(self, pipeline, options):
# TODO(chamikara): remove following pipeline and pipeline proto
recreation
# after portable job submission path is fully in place.
from apache_beam import Pipeline
- pipeline = Pipeline.from_runner_api(
+ pipeline, src_context = Pipeline.from_runner_api(
self.proto_pipeline,
pipeline.runner,
options,
+ return_context=True,
allow_proto_holders=True)
# Pipelines generated from proto do not have output set to PDone set for
# leaf elements.
pipeline.visit(self._set_pdone_visitor(pipeline))
+ from apache_beam.runners import pipeline_context
+ dst_context = pipeline_context.PipelineContext(
+ component_id_map=pipeline.component_id_map,
+ default_environment=self._default_environment)
+
+ # Copy external environments to prevent dangling environment ids
+ pipeline.visit(
Review comment:
"RunnerAPIPTransformHolder" is expected to go away soon (when we enable
portable job submission). Do you think we can skip this test (that use Python
external transforms in a Python pipeline) for now and try without these updates
when we have portable job submission ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 510433)
Time Spent: 3h 20m (was: 3h 10m)
> Enable CrossLanguageValidateRunner test for dataflow runner v2
> --------------------------------------------------------------
>
> Key: BEAM-11142
> URL: https://issues.apache.org/jira/browse/BEAM-11142
> Project: Beam
> Issue Type: Improvement
> Components: cross-language, runner-dataflow
> Reporter: Heejong Lee
> Assignee: Heejong Lee
> Priority: P2
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> Enable CrossLanguageValidateRunner test for dataflow runner v2
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
