[
https://issues.apache.org/jira/browse/BEAM-6540?focusedWorklogId=191906&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-191906
]
ASF GitHub Bot logged work on BEAM-6540:
----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Jan/19 21:47
Start Date: 29/Jan/19 21:47
Worklog Time Spent: 10m
Work Description: reuvenlax commented on pull request #7664: [BEAM-6540]
Windmill quota piping
URL: https://github.com/apache/beam/pull/7664#discussion_r252030623
##########
File path:
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/GrpcWindmillServer.java
##########
@@ -1412,4 +1451,83 @@ public void close() throws IOException {
stream.close();
}
}
+
+ /**
+ * A set of stopwatches used to track the amount of time spent throttled due
to Resource Exhausted
+ * errors. Throttle time is cumulative for all three rpcs types but not for
all streams. So if
+ * GetWork and CommitWork are both blocked for x, totalTime will be 2x.
However, if 2 GetWork
+ * streams are both blocked for x totalTime will be x. All methods are
thread safe.
+ */
+ private static class ThrottleTimer {
Review comment:
Is this called from multiple threads or only from a single one?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 191906)
Time Spent: 40m (was: 0.5h)
> Autoscaling should be aware of Streaming RPC Quota
> ---------------------------------------------------
>
> Key: BEAM-6540
> URL: https://issues.apache.org/jira/browse/BEAM-6540
> Project: Beam
> Issue Type: Improvement
> Components: runner-dataflow
> Affects Versions: 2.11.0
> Reporter: Dustin Rhodes
> Assignee: Tyler Akidau
> Priority: Major
> Fix For: 2.11.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Streaming Windmill Service introduces quota for the shared windmill workers.
> Autoscaling needs to be aware of throttling due to this quota in order to not
> upscale. This PR adds in that reporting.
>
> It also introduces the flag --EnableStreamingEngine.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
