[
https://issues.apache.org/jira/browse/BEAM-6494?focusedWorklogId=191922&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-191922
]
ASF GitHub Bot logged work on BEAM-6494:
----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Jan/19 22:38
Start Date: 29/Jan/19 22:38
Worklog Time Spent: 10m
Work Description: iemejia commented on pull request #7645: [BEAM-6494]
Fixes bug in RedisIO
URL: https://github.com/apache/beam/pull/7645
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 191922)
Time Spent: 20m (was: 10m)
> We do not sync pipeline with server at bundle end, only during teardown
> -----------------------------------------------------------------------
>
> Key: BEAM-6494
> URL: https://issues.apache.org/jira/browse/BEAM-6494
> Project: Beam
> Issue Type: Bug
> Components: io-java-redis
> Affects Versions: 2.9.0
> Reporter: Robert Collins
> Assignee: Robert Collins
> Priority: Major
> Fix For: 2.11.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The redis pipeline object only sends executed commands to the redis server
> when sync() or close() are called. If these are not called, the calls stay
> inside the buffer. As teardown is not guaranteed to be called, we should call
> pipeline.sync() inside finishBundle, after pipeline.exec().
> [docs|https://beam.apache.org/releases/javadoc/2.5.0/org/apache/beam/sdk/transforms/DoFn.Teardown.html]
>
> @FinishBundle
> public void finishBundle() {
> if (pipeline.isInMulti()) {
> pipeline.exec();
> }
> batchCount = 0;
> }
> @Teardown
> public void teardown() {
> jedis.close();
> }
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
