[
https://issues.apache.org/jira/browse/BEAM-11260?focusedWorklogId=511574&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-511574
]
ASF GitHub Bot logged work on BEAM-11260:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Nov/20 21:54
Start Date: 13/Nov/20 21:54
Worklog Time Spent: 10m
Work Description: kennknowles commented on a change in pull request
#13342:
URL: https://github.com/apache/beam/pull/13342#discussion_r523252500
##########
File path: sdks/java/build-tools/beam-linkage-check.sh
##########
@@ -36,46 +36,60 @@ set -o pipefail
set -e
# These default artifacts are common causes of linkage errors.
-ARTIFACTS="beam-sdks-java-core
- beam-sdks-java-io-google-cloud-platform
- beam-runners-google-cloud-dataflow-java
- beam-sdks-java-io-hadoop-format"
-
-if [ ! -z "$1" ]; then
- ARTIFACTS=$1
+DEFAULT_ARTIFACT_LISTS=" \
Review comment:
I noticed that we loop over this. But the gradle property uses a
comma-separated list of artifacts. Is this just a mistake or is the idea to
have a bunch of separate lists that are checked separately?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 511574)
Time Spent: 20m (was: 10m)
> Linkage check script assumes you have a remote called `origin`
> --------------------------------------------------------------
>
> Key: BEAM-11260
> URL: https://issues.apache.org/jira/browse/BEAM-11260
> Project: Beam
> Issue Type: Bug
> Components: build-system
> Reporter: Kenneth Knowles
> Priority: P2
> Labels: starter
> Time Spent: 20m
> Remaining Estimate: 0h
>
> This is not the case, and I don't have such a remote. It doesn't work in
> general.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
