[
https://issues.apache.org/jira/browse/BEAM-5091?focusedWorklogId=192007&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-192007
]
ASF GitHub Bot logged work on BEAM-5091:
----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Jan/19 03:10
Start Date: 30/Jan/19 03:10
Worklog Time Spent: 10m
Work Description: tvalentyn commented on issue #7652: [BEAM-5091] New
wordcount integration test on DataflowRunner in Python 3
URL: https://github.com/apache/beam/pull/7652#issuecomment-458795203
Thanks, @markflyhigh. I support adding a wordcount test that does not
require a main session for the purposes of improving existing Python 3
coverage. However I'd like us to have a better understanding whether we want to
keep this test after BEAM-6158 is fixed. Possible reason to keep: in the
future we may have another feature for which we will be adding test coverage
gradually, and for which --save_main_session will not work out of the box.
Reason not to keep - this test is a subset of regular wordcount test.
- If we want to keep this test, I suggest we modify
https://github.com/apache/beam/blob/master/sdks/python/apache_beam/examples/wordcount_minimal.py
to allow all pipeline options be passed as args, and write
wordcount_minimal_it on top of that pipeline.
- If we don't want to keep this test, let's make it as easy as possible to
switch current pipeline to a regular wordcount pipeline, while preserving the
consistency of how tests are organized. We could think about it this way: how
would we add a FnAPI Py3 integration test right now if we didn't have
BEAM-6158. Would we put it in
https://github.com/apache/beam/blob/master/sdks/python/apache_beam/examples/wordcount_it_test.py
?
- It looks like current test adds a new test folder, which I personally
like, however now we will have two sets of tests in different places. I would
suggest that we reorganize the suites in a different change, or move other
tests to new folder in another commit on this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 192007)
Time Spent: 40m (was: 0.5h)
> Exercise Python 3 SDK harness container in ValidatesContainer Jenkins test
> suite.
> ---------------------------------------------------------------------------------
>
> Key: BEAM-5091
> URL: https://issues.apache.org/jira/browse/BEAM-5091
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Valentyn Tymofieiev
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
