[
https://issues.apache.org/jira/browse/BEAM-7003?focusedWorklogId=512883&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-512883
]
ASF GitHub Bot logged work on BEAM-7003:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Nov/20 13:10
Start Date: 17/Nov/20 13:10
Worklog Time Spent: 10m
Work Description: aromanenko-dev commented on a change in pull request
#13026:
URL: https://github.com/apache/beam/pull/13026#discussion_r525140909
##########
File path: sdks/java/io/kafka/build.gradle
##########
@@ -65,26 +76,68 @@ dependencies {
testCompile library.java.junit
testCompile library.java.powermock
testCompile library.java.powermock_mockito
+ testCompile library.java.testcontainers_kafka
testRuntimeOnly library.java.slf4j_jdk14
testRuntimeOnly project(path: ":runners:direct-java", configuration:
"shadow")
- kafkaVersion210 "org.apache.kafka:kafka-clients:2.1.0"
+ kafkaVersions.each {"kafkaVersion$it.key"
"org.apache.kafka:kafka-clients:$it.value"}
}
-configurations.kafkaVersion210 {
- resolutionStrategy {
- force "org.apache.kafka:kafka-clients:2.1.0"
+kafkaVersions.each { kv ->
+ configurations."kafkaVersion$kv.key" {
+ resolutionStrategy {
+ force "org.apache.kafka:kafka-clients:$kv.value"
+ }
}
}
-task kafkaVersion210Test(type: Test) {
Review comment:
@boyuanzz Thanks! I guess it's should fixed now (#13356 ), right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 512883)
Time Spent: 6.5h (was: 6h 20m)
> Test KafkaIO against different versions of Kafka
> ------------------------------------------------
>
> Key: BEAM-7003
> URL: https://issues.apache.org/jira/browse/BEAM-7003
> Project: Beam
> Issue Type: Improvement
> Components: io-java-kafka
> Reporter: Ismaël Mejía
> Assignee: Piotr Szuberski
> Priority: P3
> Time Spent: 6.5h
> Remaining Estimate: 0h
>
> KafkaIO is supposed to support multiple versions of Kafka (> 0.9) but our
> current test infrastructure only validates this against the version 1.0.0. We
> should find a mecanism to parametrize KafkaIO tests with different versions
> of Kafka to ensure that multi-version support works as expected.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
