[
https://issues.apache.org/jira/browse/BEAM-10925?focusedWorklogId=514421&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-514421
]
ASF GitHub Bot logged work on BEAM-10925:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Nov/20 02:48
Start Date: 20/Nov/20 02:48
Worklog Time Spent: 10m
Work Description: ibzib commented on a change in pull request #13309:
URL: https://github.com/apache/beam/pull/13309#discussion_r527359663
##########
File path:
sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/SqlOperators.java
##########
@@ -158,7 +186,7 @@ public static SqlFunction createZetaSqlFunction(String
name, SqlTypeName returnT
SqlFunctionCategory.USER_DEFINED_FUNCTION);
}
- private static SqlUserDefinedAggFunction createUdafOperator(
+ public static SqlUserDefinedAggFunction createUdafOperator(
Review comment:
In the original PR, I used createUdfOperator in ExpressionConverter, and
createUdafOperator in AggregateScanConverter. So they can be package-private
instead of public.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 514421)
Time Spent: 14h (was: 13h 50m)
> ZetaSQL: Support Java UDF
> -------------------------
>
> Key: BEAM-10925
> URL: https://issues.apache.org/jira/browse/BEAM-10925
> Project: Beam
> Issue Type: New Feature
> Components: dsl-sql-zetasql
> Reporter: Kyle Weaver
> Assignee: Kyle Weaver
> Priority: P2
> Time Spent: 14h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
