[
https://issues.apache.org/jira/browse/BEAM-10891?focusedWorklogId=515684&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-515684
]
ASF GitHub Bot logged work on BEAM-10891:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Nov/20 17:43
Start Date: 23/Nov/20 17:43
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on a change in pull request
#12837:
URL: https://github.com/apache/beam/pull/12837#discussion_r528885075
##########
File path: Dockerfile
##########
@@ -0,0 +1,80 @@
+###############################################################################
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+###############################################################################
+
+# Dockerfile for container with dev prerequisites
+
+
+FROM ubuntu:20.04
+
+ARG DEBIAN_FRONTEND=noninteractive
+
+# Update and install common packages
+RUN apt -q update \
+ && apt install -y software-properties-common apt-utils apt-transport-https
ca-certificates \
+ && add-apt-repository -y ppa:deadsnakes/ppa \
+ && apt-get -q install -y --no-install-recommends \
+ curl \
+ gnupg-agent \
+ rsync \
+ git \
+ vim \
+ locales \
+ wget \
+ time \
+ openjdk-8-jdk \
+ python3-setuptools \
+ python3-pip \
+ python3.5 \
+ python3.6 \
+ python3.7 \
+ python2.7 \
+ virtualenv \
+ tox
+
+# Setup to install docker
+RUN curl -fsSL https://download.docker.com/linux/ubuntu/gpg | apt-key add -
+RUN apt-key fingerprint 0EBFCD88
+RUN add-apt-repository \
+ "deb [arch=amd64] https://download.docker.com/linux/ubuntu \
+ $(lsb_release -cs) \
+ stable"
+RUN apt-get install -y docker-ce docker-ce-cli containerd.io
+
+# Set the locale
Review comment:
I just verified that errorprone will raise a compile error if we use
APIs that depend on the locale. I changed an existing call to `getBytes()`:
```
> Task :sdks:java:core:compileTestJava
/usr/local/google/home/bhulette/working_dir/beam/sdks/java/core/src/test/java/org/apache/beam/sdk/util/ExposedByteArrayInputStreamTest.java:77:
warning: [DefaultCharset] Implicit use of the platform default charset, which
can result in differing behaviour between JVM executions or incorrect behavior
if the encoding of the data source doesn't match expectations.
assertArrayEquals("ello World!".getBytes(), ret);
^
(see http://errorprone.info/bugpattern/DefaultCharset)
Did you mean 'assertArrayEquals("ello World!".getBytes(UTF_8), ret);' or
'assertArrayEquals("ello World!".getBytes(Charset.defaultCharset()), ret);'?
```
We can't control if one of our dependencies is doing this though, maybe
that's what's going on. We should use this opportunity to file a jira about the
specific tests that are sensitive to locale (if one doesn't exist already)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 515684)
Time Spent: 5.5h (was: 5h 20m)
> Dockerfile for development container
> ------------------------------------
>
> Key: BEAM-10891
> URL: https://issues.apache.org/jira/browse/BEAM-10891
> Project: Beam
> Issue Type: Improvement
> Components: website
> Reporter: Omar Ismail
> Priority: P2
> Time Spent: 5.5h
> Remaining Estimate: 0h
>
> Create Dockerfile as alternative to instructions presented in
> https://beam.apache.org/contribute/#prerequisites
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
