[
https://issues.apache.org/jira/browse/BEAM-11343?focusedWorklogId=517456&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-517456
]
ASF GitHub Bot logged work on BEAM-11343:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Nov/20 20:28
Start Date: 27/Nov/20 20:28
Worklog Time Spent: 10m
Work Description: iemejia commented on a change in pull request #13427:
URL: https://github.com/apache/beam/pull/13427#discussion_r531778353
##########
File path:
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/External.java
##########
@@ -78,7 +78,7 @@
private static AtomicInteger namespaceCounter = new AtomicInteger(0);
private static final ExpansionServiceClientFactory DEFAULT =
- new DefaultExpansionServiceClientFactory(
+ DefaultExpansionServiceClientFactory.create(
Review comment:
Thanks for pointing this out! I did a quick fix now on master to unlock
other people's PRs,
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 517456)
Time Spent: 50m (was: 40m)
> Make ExpansionServiceClient accesible outside of core-construction-java
> -----------------------------------------------------------------------
>
> Key: BEAM-11343
> URL: https://issues.apache.org/jira/browse/BEAM-11343
> Project: Beam
> Issue Type: Improvement
> Components: runner-core
> Reporter: Ismaël Mejía
> Assignee: Ismaël Mejía
> Priority: P2
> Fix For: 2.27.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> {color:#000000}DefaultExpansionServiceClientFactory is the de-facto way to
> get an {color}{color:#000000}ExpansionServiceClient to request an Expansion
> used by External transforms.
> {color}
> {color:#000000}If we want to use this client to get an expansion in other
> transforms in Beam we cannot do it because even if the
> DefaultExpansionServiceClientFactory class is public the constructor and the
> objects that return are not. The idea here is to fix both so other parts of
> Beam can use it too.{color}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
