[ 
https://issues.apache.org/jira/browse/BEAM-9980?focusedWorklogId=518751&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-518751
 ]

ASF GitHub Bot logged work on BEAM-9980:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 02/Dec/20 03:43
            Start Date: 02/Dec/20 03:43
    Worklog Time Spent: 10m 
      Work Description: tvalentyn commented on a change in pull request #13426:
URL: https://github.com/apache/beam/pull/13426#discussion_r533876617



##########
File path: .test-infra/jenkins/PythonTestProperties.groovy
##########
@@ -24,7 +24,9 @@ class PythonTestProperties {
     '3.7',
     '3.8'
   ]
-  final static List<String> SUPPORTED_CONTAINER_TASKS = ['py36', 'py37', 
'py38']
+  final static List<String> SUPPORTED_CONTAINER_TASKS = 
ALL_SUPPORTED_VERSIONS.stream().map {

Review comment:
       How about we simplify this to:
   ```
   SUPPORTED_CONTAINER_TASKS = ALL_SUPPORTED_VERSIONS.collect 
{"py${it.replace('.', '')}"}
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 518751)
    Time Spent: 19h  (was: 18h 50m)

> Do not hardcode Python versions in test suites, instead make it configurable.
> -----------------------------------------------------------------------------
>
>                 Key: BEAM-9980
>                 URL: https://issues.apache.org/jira/browse/BEAM-9980
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-py-core
>            Reporter: yoshiki obata
>            Priority: P2
>          Time Spent: 19h
>  Remaining Estimate: 0h
>
> We have some tests that we run only under specific Python versions,
> - FlinkValidatesRunner test runs using Python 3.5
> - HDFS Python 3 tests are running only with Python 3.7
> - Cross-language Py3 tests for Spark are running under Python 3.5
>     etc...
> Python versions to run them under need to be switchable.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to