[
https://issues.apache.org/jira/browse/BEAM-11383?focusedWorklogId=520349&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-520349
]
ASF GitHub Bot logged work on BEAM-11383:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Dec/20 21:26
Start Date: 04/Dec/20 21:26
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on a change in pull request
#13464:
URL: https://github.com/apache/beam/pull/13464#discussion_r536388649
##########
File path:
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -770,6 +770,10 @@ class BeamModulePlugin implements Plugin<Project> {
+ (defaultLintSuppressions +
configuration.disableLintWarnings).collect { "-Xlint:-${it}" })
}
+ project.tasks.withType(Jar).configureEach {
+ preserveFileTimestamps(false)
+ }
+
Review comment:
Ah yes I guess applyJavaNature is called in applyPortabilityNature
already so this caputres both :+1:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 520349)
Time Spent: 1h 10m (was: 1h)
> Normalize build timestamp in sdk.properties to avoid re-running tasks
> ---------------------------------------------------------------------
>
> Key: BEAM-11383
> URL: https://issues.apache.org/jira/browse/BEAM-11383
> Project: Beam
> Issue Type: Bug
> Components: build-system
> Reporter: Nelson Osacky
> Assignee: Nelson Osacky
> Priority: P2
> Attachments: Screen Shot 2020-12-02 at 6.57.07 PM.png
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> The build timestamp in the sdk.properties file is regenerated on every
> invocation meaning that certain tasks would always be considered out of date.
> If we normalize the sdk.properties file we could avoid unecessarily
> re-running tasks that do no use the timestamp.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
