[
https://issues.apache.org/jira/browse/BEAM-10703?focusedWorklogId=520387&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-520387
]
ASF GitHub Bot logged work on BEAM-10703:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Dec/20 00:34
Start Date: 05/Dec/20 00:34
Worklog Time Spent: 10m
Work Description: boyuanzz commented on a change in pull request #13405:
URL: https://github.com/apache/beam/pull/13405#discussion_r536461389
##########
File path: sdks/python/apache_beam/runners/dataflow/ptransform_overrides.py
##########
@@ -329,3 +330,44 @@ def expand(self, pcoll):
return {key: out for key in self.outputs}
return WriteToBigQuery(ptransform, self.outputs)
+
+
+class GroupIntoBatchesWithShardedKeyPTransformOverride(PTransformOverride):
+ """A ``PTransformOverride`` for ``GroupIntoBatches.WithShardedKey``.
+
+ This override simply returns the original transform but additionally records
+ the output PCollection in order to append required step properties during
+ graph translation.
+ """
+ def __init__(self, dataflow_runner, options):
+ self.dataflow_runner = dataflow_runner
+ self.options = options
+
+ def matches(self, applied_ptransform):
+ # Imported here to avoid circular dependencies.
+ # pylint: disable=wrong-import-order, wrong-import-position
+ from apache_beam import util
+
+ transform = applied_ptransform.transform
+
+ if not isinstance(transform, util.GroupIntoBatches.WithShardedKey):
+ return False
+
+ # The replacement is only valid for portable Streaming Engine jobs.
+ standard_options = self.options.view_as(StandardOptions)
+ if not standard_options.streaming:
+ return False
+ google_cloud_options = self.options.view_as(GoogleCloudOptions)
+ if not google_cloud_options.enable_streaming_engine:
+ return False
+ experiments = self.options.view_as(DebugOptions).experiments or []
+ if 'beam_fn_api' not in experiments:
Review comment:
Yeah it should just work on JRH. My question is that do we want to do
the expansion even though we know that we are not going to shard it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 520387)
Time Spent: 13h 10m (was: 13h)
> Add support for auto-sharded GroupIntoBatches in Dataflow runner
> ----------------------------------------------------------------
>
> Key: BEAM-10703
> URL: https://issues.apache.org/jira/browse/BEAM-10703
> Project: Beam
> Issue Type: Improvement
> Components: runner-dataflow
> Reporter: Siyuan Chen
> Assignee: Siyuan Chen
> Priority: P1
> Time Spent: 13h 10m
> Remaining Estimate: 0h
>
> The proposal of improving GroupIntoBatches transform is in BEAM-10475
> This tracks the support in Cloud Dataflow Runner.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
