[
https://issues.apache.org/jira/browse/BEAM-11394?focusedWorklogId=521401&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-521401
]
ASF GitHub Bot logged work on BEAM-11394:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Dec/20 21:51
Start Date: 07/Dec/20 21:51
Worklog Time Spent: 10m
Work Description: TheNeuralBit commented on a change in pull request
#13487:
URL: https://github.com/apache/beam/pull/13487#discussion_r537858120
##########
File path: sdks/python/apache_beam/options/pipeline_options.py
##########
@@ -1176,6 +1176,12 @@ def _add_argparse_args(cls, parser):
default=0,
help='Port to use for artifact staging. 0 to use a '
'dynamic port.')
+ parser.add_argument(
+ '--java_launcher',
+ default='java',
+ help='The Java Application Launcher executable file to use for '
+ 'starting a Java job server. If unset, `java` from the '
+ 'environment\'s $PATH is used.')
Review comment:
you noted the expansion service isn't affected by this PR - _should_
this arg affect the expansion service launcher as well, or should that be
configured separately?
If the former why not go ahead and wire it up
If the latter this should be `java_job_server_launcher` (or something) to
disambiguate from a possible future param for expansion services.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 521401)
Time Spent: 0.5h (was: 20m)
> Make Java launcher configurable in pipeline options.
> ----------------------------------------------------
>
> Key: BEAM-11394
> URL: https://issues.apache.org/jira/browse/BEAM-11394
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Reporter: Kyle Weaver
> Assignee: Kyle Weaver
> Priority: P2
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> We need Java to run job servers, expansion services etc. in subprocesses [1]
> and [2] (and possibly elsewhere I have missed?). Currently this code always
> uses the "java" executable on the $PATH. But changing $PATH or adding an
> alias is a global(ish) change, and it's cumbersome, or even impossible in
> some environments (Forge). Having a pipeline option for it is easier and
> better isolated.
> [1]
> https://github.com/apache/beam/blob/master/sdks/python/apache_beam/utils/subprocess_server.py
> [2]
> https://github.com/apache/beam/blob/master/sdks/python/apache_beam/runners/portability/job_server.py
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
