[
https://issues.apache.org/jira/browse/BEAM-5658?focusedWorklogId=193008&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-193008
]
ASF GitHub Bot logged work on BEAM-5658:
----------------------------------------
Author: ASF GitHub Bot
Created on: 31/Jan/19 20:04
Start Date: 31/Jan/19 20:04
Worklog Time Spent: 10m
Work Description: kennknowles commented on pull request #7684:
[BEAM-5658] Re-enable findbugs on Dataflow worker
URL: https://github.com/apache/beam/pull/7684#discussion_r252797847
##########
File path:
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/AvroByteReaderFactory.java
##########
@@ -53,6 +54,8 @@ public AvroByteReaderFactory() {}
@Nullable DataflowExecutionContext executionContext,
Review comment:
There's an interesting tension here. The superclass declares then
`@Nullable` so they certainly _can_ be null. Removing the annotation just
leaves a false sense of security. See elsewhere where findbugs erroneously
forced me to remove the annotation. I leave a comment and a `checkArgument` in
place for posterity.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 193008)
Time Spent: 2h 20m (was: 2h 10m)
> Enable FindBugs in dataflow java worker code
> --------------------------------------------
>
> Key: BEAM-5658
> URL: https://issues.apache.org/jira/browse/BEAM-5658
> Project: Beam
> Issue Type: Test
> Components: runner-dataflow
> Reporter: Boyuan Zhang
> Assignee: Kenneth Knowles
> Priority: Critical
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> Currently we disabled FindBugs task in worker code. We should enable if after
> fixing all related warnings and errors.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
