[
https://issues.apache.org/jira/browse/BEAM-11474?focusedWorklogId=524678&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-524678
]
ASF GitHub Bot logged work on BEAM-11474:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Dec/20 20:00
Start Date: 15/Dec/20 20:00
Worklog Time Spent: 10m
Work Description: y1chi commented on a change in pull request #13533:
URL: https://github.com/apache/beam/pull/13533#discussion_r543647354
##########
File path:
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/TransformProcessingThreadTracker.java
##########
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.fn.harness;
+
+import java.util.concurrent.ConcurrentHashMap;
+
+/**
+ * TransformProcessingThreadTracker tracks the thread ids for the transforms
that are being
+ * processed in the SDK harness.
+ */
+public class TransformProcessingThreadTracker {
Review comment:
I think there might be a very slight chance the processing thread moved
onto another transform when the LogHandler haven't done transforming the log
entries in previous one. But I think the it should be very rare(log transform
should be almost instant) and I would argue that it's probably better to keep
the logging just best practice instead of introducing locks to guarantee 100%
metadata correctness?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 524678)
Time Spent: 20m (was: 10m)
> Populate transform id field in Java SDK harness logs.
> -----------------------------------------------------
>
> Key: BEAM-11474
> URL: https://issues.apache.org/jira/browse/BEAM-11474
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-harness
> Reporter: Yichi Zhang
> Assignee: Yichi Zhang
> Priority: P2
> Time Spent: 20m
> Remaining Estimate: 0h
>
> The Java SDK harness currently doesn't associate transform id with the logs
> sent to the runner.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
