[
https://issues.apache.org/jira/browse/BEAM-11360?focusedWorklogId=524693&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-524693
]
ASF GitHub Bot logged work on BEAM-11360:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Dec/20 20:28
Start Date: 15/Dec/20 20:28
Worklog Time Spent: 10m
Work Description: chamikaramj commented on a change in pull request
#13536:
URL: https://github.com/apache/beam/pull/13536#discussion_r543659576
##########
File path: sdks/python/apache_beam/pipeline.py
##########
@@ -509,19 +514,25 @@ def run(self, test_runner_api='AUTO'):
self.runner.__class__.__name__ == 'SwitchingDirectRunner' and
not self._options.view_as(StandardOptions).streaming)
+ # Multi-language pipelines that contain external pipeline segments may
+ # not be able to create a Python pipeline object graph. Hence following
+ # runner API check should be skipped for such pipelines.
+ external_transform_finder = ExternalTransformFinder()
+ self.visit(external_transform_finder)
Review comment:
This was redundant. Updated.
Also, updated the visitor class by adding a static method like you
mentioned.
##########
File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner.py
##########
@@ -580,6 +533,11 @@ def run_pipeline(self, pipeline, options):
debug_options.add_experiment(
'min_cpu_platform=' + worker_options.min_cpu_platform)
+ if pipeline.contains_external_transforms:
+ # All Dataflow multi-language pipelines use portable job submission by
+ # default.
+ debug_options.add_experiment("use_portable_job_submission")
Review comment:
Yes, updated to also include a Runner v2 check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 524693)
Time Spent: 40m (was: 0.5h)
> Enable portable job submission for Dataflow multi-language pipelines (Python
> SDK)
> ---------------------------------------------------------------------------------
>
> Key: BEAM-11360
> URL: https://issues.apache.org/jira/browse/BEAM-11360
> Project: Beam
> Issue Type: Improvement
> Components: runner-dataflow
> Reporter: Chamikara Madhusanka Jayalath
> Assignee: Chamikara Madhusanka Jayalath
> Priority: P2
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Corresponding Java changes should be tracked separately.
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
