[ 
https://issues.apache.org/jira/browse/BEAM-11474?focusedWorklogId=524773&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-524773
 ]

ASF GitHub Bot logged work on BEAM-11474:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 16/Dec/20 00:15
            Start Date: 16/Dec/20 00:15
    Worklog Time Spent: 10m 
      Work Description: boyuanzz commented on a change in pull request #13533:
URL: https://github.com/apache/beam/pull/13533#discussion_r543781511



##########
File path: 
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/TransformProcessingThreadTracker.java
##########
@@ -0,0 +1,46 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.fn.harness;
+
+import java.util.concurrent.ConcurrentHashMap;
+
+/**
+ * TransformProcessingThreadTracker tracks the thread ids for the transforms 
that are being
+ * processed in the SDK harness.
+ */
+public class TransformProcessingThreadTracker {
+  private static final TransformProcessingThreadTracker INSTANCE =
+      new TransformProcessingThreadTracker();
+  private final ConcurrentHashMap<Long, String> threadIdToTransformIdMappings;

Review comment:
       Another question is that will this map grow unlimitedly? I'm kind of 
concerning that it consumes too much memory with a long run instance(and the 
thread is not reused).




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 524773)
    Time Spent: 2h 10m  (was: 2h)

> Populate transform id field in Java SDK harness logs.
> -----------------------------------------------------
>
>                 Key: BEAM-11474
>                 URL: https://issues.apache.org/jira/browse/BEAM-11474
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-harness
>            Reporter: Yichi Zhang
>            Assignee: Yichi Zhang
>            Priority: P2
>          Time Spent: 2h 10m
>  Remaining Estimate: 0h
>
> The Java SDK harness currently doesn't associate transform id with the logs 
> sent to the runner.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to