[
https://issues.apache.org/jira/browse/BEAM-10925?focusedWorklogId=524807&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-524807
]
ASF GitHub Bot logged work on BEAM-10925:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Dec/20 03:16
Start Date: 16/Dec/20 03:16
Worklog Time Spent: 10m
Work Description: ibzib commented on pull request #13306:
URL: https://github.com/apache/beam/pull/13306#issuecomment-745736494
As requested I rewrote this without a dependency on Beam Java core. Right
now it is a shameless copy-paste of some stuff from `CombineFn`, since the
implementation will still depend on CombineFn anyway. But now we're decoupled
at the API level, so we have more flexibility to make whatever changes are
needed later (such as Kenn's suggestion to add a SQL type).
> I don't agree in this case that creating a wrapper is trivial. For
UDAF/CombeFn, I think it is non-trival work to create the wrapper.
There already is a wrapper that's basically the same as what we're doing
here:
https://github.com/apache/beam/blob/release-2.25.0/sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/transform/agg/AggregationCombineFnAdapter.java
Anyway, I will figure it out :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 524807)
Time Spent: 15h 10m (was: 15h)
> ZetaSQL: Support Java UDF
> -------------------------
>
> Key: BEAM-10925
> URL: https://issues.apache.org/jira/browse/BEAM-10925
> Project: Beam
> Issue Type: New Feature
> Components: dsl-sql-zetasql
> Reporter: Kyle Weaver
> Assignee: Kyle Weaver
> Priority: P2
> Time Spent: 15h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
