[
https://issues.apache.org/jira/browse/BEAM-11482?focusedWorklogId=526375&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-526375
]
ASF GitHub Bot logged work on BEAM-11482:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Dec/20 21:06
Start Date: 19/Dec/20 21:06
Worklog Time Spent: 10m
Work Description: piotr-szuberski commented on a change in pull request
#13572:
URL: https://github.com/apache/beam/pull/13572#discussion_r546282430
##########
File path:
sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/meta/provider/kafka/KafkaTableProviderThriftIT.java
##########
@@ -0,0 +1,62 @@
+/*
Review comment:
The last comment from me. Could you also add a test that will run on SQL
precommit as well? You could use the same thrift file as in the IT test.
Example here:
https://github.com/apache/beam/blob/1466db958ca22222ae8badf1f21a860267d46d31/sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/meta/provider/kafka/BeamKafkaTableAvroTest.java#L31
And a unit test `testBuildBeamSqlThriftTable` for thrift table creation,
like here:
https://github.com/apache/beam/blob/1466db958ca22222ae8badf1f21a860267d46d31/sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/meta/provider/kafka/KafkaTableProviderTest.java#L66
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 526375)
Time Spent: 2.5h (was: 2h 20m)
> Thrift support for KafkaTableProvider
> -------------------------------------
>
> Key: BEAM-11482
> URL: https://issues.apache.org/jira/browse/BEAM-11482
> Project: Beam
> Issue Type: New Feature
> Components: dsl-sql, io-java-kafka
> Reporter: Costi Ciudatu
> Assignee: Costi Ciudatu
> Priority: P2
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> Kafka table provider can leverage the Thrift coder and schema provider
> defined in the IO package to handle thrift input/output.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
