[
https://issues.apache.org/jira/browse/BEAM-6554?focusedWorklogId=193968&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-193968
]
ASF GitHub Bot logged work on BEAM-6554:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Feb/19 12:06
Start Date: 04/Feb/19 12:06
Worklog Time Spent: 10m
Work Description: adude3141 commented on pull request #7704: [BEAM-6554]
Migrate from findbugs to spotbugs
URL: https://github.com/apache/beam/pull/7704#discussion_r253444031
##########
File path:
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
##########
@@ -756,15 +754,15 @@ class BeamModulePlugin implements Plugin<Project> {
// Enables a plugin which performs code analysis for common bugs.
// This plugin is configured to only analyze the "main" source set.
if (configuration.enableFindbugs) {
- project.apply plugin: 'findbugs'
- project.findbugs {
+ project.apply plugin: 'com.github.spotbugs'
+ project.spotbugs {
excludeFilter =
project.rootProject.file('sdks/java/build-tools/src/main/resources/beam/findbugs-filter.xml')
sourceSets = [sourceSets.main]
}
- project.tasks.withType(FindBugs) {
+ project.tasks.withType(com.github.spotbugs.SpotBugsTask) {
reports {
- html.enabled = false
- xml.enabled = true
+ html { enabled = true }
Review comment:
definitely+1 on having decent developer defaults.
Unfortunately the Jenkins plugin requires xml output. And as
findbugs/spotbugs support only single report format and I further was under the
impression that findbugs should be removed, I simply switch to xml. Of course,
this is a different story now.
Regarding that parameter, do we have other places where we have different
configuration on jenkins? If so, would it make sense to extract some
Jenkins-plugin which collects all this differences, so that we only either
autodetect, we run on Jenkins (by checking some Jenkins env-var) or set only a
single parameter, ciBuild=true or such.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 193968)
Time Spent: 0.5h (was: 20m)
> Consider spotbugs to replace findbugs
> -------------------------------------
>
> Key: BEAM-6554
> URL: https://issues.apache.org/jira/browse/BEAM-6554
> Project: Beam
> Issue Type: Test
> Components: build-system
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
