[
https://issues.apache.org/jira/browse/BEAM-3306?focusedWorklogId=194336&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-194336
]
ASF GitHub Bot logged work on BEAM-3306:
----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Feb/19 00:26
Start Date: 05/Feb/19 00:26
Worklog Time Spent: 10m
Work Description: lostluck commented on pull request #7723: [BEAM-3306]
Add first pass coder registry for Go
URL: https://github.com/apache/beam/pull/7723#discussion_r253699728
##########
File path: sdks/go/pkg/beam/core/graph/coder/coder.go
##########
@@ -86,24 +92,43 @@ var (
OptReturn: []reflect.Type{reflectx.Error}}
)
+func validateEncoder(t reflect.Type, encode interface{}) error {
+ // Check if it uses the real type in question.
+ if err := funcx.Satisfy(encode, funcx.Replace(encodeSig, typex.TType,
t)); err != nil {
+ return fmt.Errorf("encode has incorrect signature: %v", err)
Review comment:
Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 194336)
Time Spent: 1.5h (was: 1h 20m)
> Consider: Go coder registry
> ---------------------------
>
> Key: BEAM-3306
> URL: https://issues.apache.org/jira/browse/BEAM-3306
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go
> Reporter: Henning Rohde
> Assignee: Robert Burke
> Priority: Minor
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
> Add coder registry to allow easier overwrite of default coders. We may also
> allow otherwise un-encodable types, but that would require that function
> analysis depends on it.
> If we're hardcoding support for proto/avro, then there may be little need for
> such a feature. Conversely, this may be how we implement such support.
>
> Proposal Doc:
> [https://docs.google.com/document/d/1kQwx4Ah6PzG8z2ZMuNsNEXkGsLXm6gADOZaIO7reUOg/edit#|https://docs.google.com/document/d/1kQwx4Ah6PzG8z2ZMuNsNEXkGsLXm6gADOZaIO7reUOg/edit]
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
