[
https://issues.apache.org/jira/browse/BEAM-6392?focusedWorklogId=194823&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-194823
]
ASF GitHub Bot logged work on BEAM-6392:
----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Feb/19 21:42
Start Date: 05/Feb/19 21:42
Worklog Time Spent: 10m
Work Description: chamikaramj commented on pull request #7441:
[BEAM-6392] Add support for the BigQuery read API to BigQueryIO.
URL: https://github.com/apache/beam/pull/7441#discussion_r254052761
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryStorageStreamSource.java
##########
@@ -0,0 +1,235 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.sdk.io.gcp.bigquery;
+
+import static
org.apache.beam.sdk.io.gcp.bigquery.BigQueryHelpers.fromJsonString;
+import static org.apache.beam.sdk.io.gcp.bigquery.BigQueryHelpers.toJsonString;
+import static
org.apache.beam.vendor.guava.v20_0.com.google.common.base.Preconditions.checkNotNull;
+
+import com.google.api.services.bigquery.model.TableSchema;
+import com.google.cloud.bigquery.storage.v1beta1.Storage.ReadRowsRequest;
+import com.google.cloud.bigquery.storage.v1beta1.Storage.ReadRowsResponse;
+import com.google.cloud.bigquery.storage.v1beta1.Storage.ReadSession;
+import com.google.cloud.bigquery.storage.v1beta1.Storage.Stream;
+import com.google.cloud.bigquery.storage.v1beta1.Storage.StreamPosition;
+import java.io.IOException;
+import java.util.Iterator;
+import java.util.List;
+import java.util.NoSuchElementException;
+import org.apache.avro.Schema;
+import org.apache.avro.generic.GenericDatumReader;
+import org.apache.avro.generic.GenericRecord;
+import org.apache.avro.io.BinaryDecoder;
+import org.apache.avro.io.DatumReader;
+import org.apache.avro.io.DecoderFactory;
+import org.apache.beam.sdk.annotations.Experimental;
+import org.apache.beam.sdk.coders.Coder;
+import org.apache.beam.sdk.io.OffsetBasedSource;
+import org.apache.beam.sdk.io.gcp.bigquery.BigQueryServices.StorageClient;
+import org.apache.beam.sdk.options.PipelineOptions;
+import org.apache.beam.sdk.transforms.SerializableFunction;
+import org.apache.beam.sdk.transforms.display.DisplayData;
+import
org.apache.beam.vendor.guava.v20_0.com.google.common.collect.ImmutableList;
+
+/** A {@link org.apache.beam.sdk.io.Source} representing a single stream in a
read session. */
+@Experimental(Experimental.Kind.SOURCE_SINK)
+public class BigQueryStorageStreamSource<T> extends OffsetBasedSource<T> {
+
+ public static <T> BigQueryStorageStreamSource<T> create(
+ ReadSession readSession,
+ Stream stream,
+ TableSchema tableSchema,
+ SerializableFunction<SchemaAndRecord, T> parseFn,
+ Coder<T> outputCoder,
+ BigQueryServices bqServices) {
+ return new BigQueryStorageStreamSource<>(
+ readSession,
+ stream,
+ 0L,
+ Long.MAX_VALUE,
+ 1L,
+ toJsonString(checkNotNull(tableSchema, "tableSchema")),
+ parseFn,
+ outputCoder,
+ bqServices);
+ }
+
+ private final ReadSession readSession;
+ private final Stream stream;
+ private final String jsonTableSchema;
+ private final SerializableFunction<SchemaAndRecord, T> parseFn;
+ private final Coder<T> outputCoder;
+ private final BigQueryServices bqServices;
+
+ private BigQueryStorageStreamSource(
+ ReadSession readSession,
+ Stream stream,
+ long startOffset,
+ long stopOffset,
+ long minBundleSize,
+ String jsonTableSchema,
+ SerializableFunction<SchemaAndRecord, T> parseFn,
+ Coder<T> outputCoder,
+ BigQueryServices bqServices) {
+ super(startOffset, stopOffset, minBundleSize);
+ this.readSession = checkNotNull(readSession, "readSession");
+ this.stream = checkNotNull(stream, "stream");
+ this.jsonTableSchema = checkNotNull(jsonTableSchema, "jsonTableSchema");
+ this.parseFn = checkNotNull(parseFn, "parseFn");
+ this.outputCoder = checkNotNull(outputCoder, "outputCoder");
+ this.bqServices = checkNotNull(bqServices, "bqServices");
+ }
+
+ @Override
+ public Coder<T> getOutputCoder() {
+ return outputCoder;
+ }
+
+ @Override
+ public void populateDisplayData(DisplayData.Builder builder) {
+ super.populateDisplayData(builder);
+ builder
+ .addIfNotNull(
+ DisplayData.item("table",
BigQueryHelpers.toTableSpec(readSession.getTableReference()))
+ .withLabel("Table"))
+ .add(DisplayData.item("readSession",
readSession.getName()).withLabel("Read session"))
+ .add(DisplayData.item("stream", stream.getName()).withLabel("Stream"));
+ }
+
+ @Override
+ public long getEstimatedSizeBytes(PipelineOptions options) {
+ // The size of stream source can't be estimated due to server-side liquid
sharding.
+ return 0L;
Review comment:
Probably add a TODO to better support this in the future ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 194823)
Time Spent: 1h 20m (was: 1h 10m)
> Add support for new BigQuery streaming read API to BigQueryIO
> -------------------------------------------------------------
>
> Key: BEAM-6392
> URL: https://issues.apache.org/jira/browse/BEAM-6392
> Project: Beam
> Issue Type: New Feature
> Components: io-java-gcp
> Reporter: Kenneth Jung
> Assignee: Kenneth Jung
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> BigQuery has developed a new streaming egress API which will soon reach
> public availability. Add support for the new API in BigQueryIO.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
