[
https://issues.apache.org/jira/browse/BEAM-11715?focusedWorklogId=547198&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-547198
]
ASF GitHub Bot logged work on BEAM-11715:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Feb/21 18:21
Start Date: 03/Feb/21 18:21
Worklog Time Spent: 10m
Work Description: codecov[bot] edited a comment on pull request #13883:
URL: https://github.com/apache/beam/pull/13883#issuecomment-772124408
# [Codecov](https://codecov.io/gh/apache/beam/pull/13883?src=pr&el=h1) Report
> Merging
[#13883](https://codecov.io/gh/apache/beam/pull/13883?src=pr&el=desc) (2f008bc)
into
[release-2.28.0](https://codecov.io/gh/apache/beam/commit/091cd880f6cbb6b60b08d0ce34113cd71ba6280a?el=desc)
(091cd88) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/beam/pull/13883?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## release-2.28.0 #13883 +/- ##
==================================================
- Coverage 82.84% 82.83% -0.02%
==================================================
Files 466 466
Lines 57584 57584
==================================================
- Hits 47705 47699 -6
- Misses 9879 9885 +6
```
| [Impacted
Files](https://codecov.io/gh/apache/beam/pull/13883?src=pr&el=tree) | Coverage
Δ | |
|---|---|---|
|
[sdks/python/apache\_beam/utils/interactive\_utils.py](https://codecov.io/gh/apache/beam/pull/13883/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdXRpbHMvaW50ZXJhY3RpdmVfdXRpbHMucHk=)
| `92.85% <0.00%> (-2.39%)` | :arrow_down: |
|
[...ks/python/apache\_beam/runners/worker/data\_plane.py](https://codecov.io/gh/apache/beam/pull/13883/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvZGF0YV9wbGFuZS5weQ==)
| `89.52% <0.00%> (-1.80%)` | :arrow_down: |
|
[.../python/apache\_beam/transforms/periodicsequence.py](https://codecov.io/gh/apache/beam/pull/13883/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9wZXJpb2RpY3NlcXVlbmNlLnB5)
| `96.49% <0.00%> (-1.76%)` | :arrow_down: |
|
[...ks/python/apache\_beam/runners/worker/sdk\_worker.py](https://codecov.io/gh/apache/beam/pull/13883/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvc2RrX3dvcmtlci5weQ==)
| `89.69% <0.00%> (-0.16%)` | :arrow_down: |
|
[setup.py](https://codecov.io/gh/apache/beam/pull/13883/diff?src=pr&el=tree#diff-c2V0dXAucHk=)
| `0.00% <0.00%> (ø)` | |
|
[sdks/python/apache\_beam/runners/common.py](https://codecov.io/gh/apache/beam/pull/13883/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9jb21tb24ucHk=)
| `88.87% <0.00%> (+0.14%)` | :arrow_up: |
|
[sdks/python/apache\_beam/io/iobase.py](https://codecov.io/gh/apache/beam/pull/13883/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW8vaW9iYXNlLnB5)
| `84.81% <0.00%> (+0.26%)` | :arrow_up: |
|
[sdks/python/apache\_beam/internal/metrics/metric.py](https://codecov.io/gh/apache/beam/pull/13883/diff?src=pr&el=tree#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vaW50ZXJuYWwvbWV0cmljcy9tZXRyaWMucHk=)
| `87.50% <0.00%> (+1.04%)` | :arrow_up: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/beam/pull/13883?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/beam/pull/13883?src=pr&el=footer). Last
update
[79929ca...2f008bc](https://codecov.io/gh/apache/beam/pull/13883?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 547198)
Time Spent: 6h 20m (was: 6h 10m)
> Combiner packing creates an incorrect proto
> -------------------------------------------
>
> Key: BEAM-11715
> URL: https://issues.apache.org/jira/browse/BEAM-11715
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Chamikara Madhusanka Jayalath
> Assignee: Yifan Mai
> Priority: P1
> Fix For: 2.28.0
>
> Time Spent: 6h 20m
> Remaining Estimate: 0h
>
> Seems like optimization creates a CombinePerKey transform that does not have
> any sub-transforms. We should fix this by preserving the old structure for
> CombinePerKey (GBK+CombineValues composite).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
