[
https://issues.apache.org/jira/browse/BEAM-3837?focusedWorklogId=197485&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-197485
]
ASF GitHub Bot logged work on BEAM-3837:
----------------------------------------
Author: ASF GitHub Bot
Created on: 12/Feb/19 10:28
Start Date: 12/Feb/19 10:28
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #7801: [BEAM-3837]
More complete test for try-split.
URL: https://github.com/apache/beam/pull/7801#discussion_r255887555
##########
File path: sdks/python/apache_beam/runners/portability/fn_api_runner.py
##########
@@ -1008,10 +1009,11 @@ def start_worker(self):
self.control_address, worker_count=self._num_threads)
self.worker_thread = threading.Thread(
name='run_worker', target=self.worker.run)
+ self.worker_thread.daemon = True
self.worker_thread.start()
def stop_worker(self):
- self.worker_thread.join()
+ self.worker_thread.join(1)
Review comment:
It's unclear whether it's better to hang forever or leave it running if the
worker has a bug, but I've reverted it for now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 197485)
Time Spent: 2.5h (was: 2h 20m)
> Python SDK harness should understand a BundleSplitRequest and respond with a
> BundleSplit before bundle finishes
> ---------------------------------------------------------------------------------------------------------------
>
> Key: BEAM-3837
> URL: https://issues.apache.org/jira/browse/BEAM-3837
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-harness
> Reporter: Eugene Kirpichov
> Assignee: Chamikara Jayalath
> Priority: Major
> Labels: triaged
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> Like BEAM-3836 but for Python SDK harness.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
