[
https://issues.apache.org/jira/browse/BEAM-11945?focusedWorklogId=570709&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-570709
]
ASF GitHub Bot logged work on BEAM-11945:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Mar/21 18:50
Start Date: 23/Mar/21 18:50
Worklog Time Spent: 10m
Work Description: amaliujia commented on a change in pull request #14197:
URL: https://github.com/apache/beam/pull/14197#discussion_r599846026
##########
File path:
runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/environment/EmbeddedEnvironmentFactory.java
##########
@@ -102,6 +102,7 @@ public RemoteEnvironment createEnvironment(Environment
environment, String worke
options,
loggingServer.getApiServiceDescriptor(),
controlServer.getApiServiceDescriptor(),
+ null,
Review comment:
Setting `null` seems a bit scary. Is there a better way to specify this
value? Like a default/empty value instead of setting a `null`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 570709)
Time Spent: 1.5h (was: 1h 20m)
> Add debug capture for SDK harness
> ---------------------------------
>
> Key: BEAM-11945
> URL: https://issues.apache.org/jira/browse/BEAM-11945
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-harness
> Reporter: Kiley Sok
> Assignee: Kiley Sok
> Priority: P2
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
