[
https://issues.apache.org/jira/browse/BEAM-449?focusedWorklogId=572738&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-572738
]
ASF GitHub Bot logged work on BEAM-449:
---------------------------------------
Author: ASF GitHub Bot
Created on: 26/Mar/21 16:41
Start Date: 26/Mar/21 16:41
Worklog Time Spent: 10m
Work Description: kennknowles commented on a change in pull request
#14322:
URL: https://github.com/apache/beam/pull/14322#discussion_r602433042
##########
File path:
sdks/java/core/src/test/java/org/apache/beam/sdk/testing/PAssertTest.java
##########
@@ -596,4 +598,138 @@ public void countAssertsMultipleCallsIndependent() {
assertThat(PAssert.countAsserts(pipeline), equalTo(3));
}
+
+ @Test
+ public void testPAssertThatFlattened() {
Review comment:
I think this needs `@Category(NeedsRunner.class)` which will cause it to
be executed on the direct runner in the `:runners:direct-java:needsRunnerTests`
task. See here:
https://scans.gradle.com/s/rlhjzeofa5ytc/tests?toggled=WyI6cnVubmVyczpkaXJlY3QtamF2YS1uZWVkc3J1bm5lcnRlc3RzLW9yZy5hcGFjaGUuYmVhbS5zZGsuaW8iLCI6cnVubmVyczpkaXJlY3QtamF2YS1uZWVkc3J1bm5lcnRlc3RzLW9yZy5hcGFjaGUuYmVhbS5zZGsudHJhbnNmb3JtcyIsIjpydW5uZXJzOmRpcmVjdC1qYXZhLW5lZWRzcnVubmVydGVzdHMtb3JnLmFwYWNoZS5iZWFtLnNkay5zY2hlbWFzLnRyYW5zZm9ybXMiXQ#:runners:direct-java-needsrunnertests-org.apache.beam.sdk.testing-passerttest
This test was executed in 66ms according to Jenkins but in fact the
`:sdks:java:core:test` task was pulled FROM-CACHE as I guess a prior run on
this PR populated the cache:
https://scans.gradle.com/s/rlhjzeofa5ytc/timeline#cblz6an6jai7a
I am actually surprised it did not fail since it should have abandoned node
enforcement, which is a feature of the `@Rule TestPipeline` to protect users
from writing tests but forgetting to run the pipeline.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 572738)
Time Spent: 1h 20m (was: 1h 10m)
> Support PCollectionList in PAssert
> ----------------------------------
>
> Key: BEAM-449
> URL: https://issues.apache.org/jira/browse/BEAM-449
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Thomas Groh
> Assignee: Vitaly Terentyev
> Priority: P3
> Labels: Clarified
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> The assertion takes an input PCollectionList and takes a list of matchers of
> the same size, and applies each matcher to the identical index of the
> PCollectionList
> e.g. PAssert.that(PCollectionList[0]).satisfies(matchers[0])
> Potentially also worthwhile is a "PAssert.thatFlattened(PCollectionList)"
> static constructor, that runs an assertion on the flattened contents of the
> list.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
