[
https://issues.apache.org/jira/browse/BEAM-12209?focusedWorklogId=587661&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-587661
]
ASF GitHub Bot logged work on BEAM-12209:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Apr/21 07:05
Start Date: 23/Apr/21 07:05
Worklog Time Spent: 10m
Work Description: scwhittle commented on a change in pull request #14617:
URL: https://github.com/apache/beam/pull/14617#discussion_r618987040
##########
File path:
sdks/java/fn-execution/src/main/java/org/apache/beam/sdk/fn/stream/DirectStreamObserver.java
##########
@@ -59,9 +60,8 @@ public DirectStreamObserver(Phaser phaser,
CallStreamObserver<T> outboundObserve
@Override
public void onNext(T value) {
Review comment:
Yes, I saw Luke mention on some other thread these observers are
supposed to be threadsafe. An example is the BeamFnControlClient which calls
this from different threads on the executor. And this class is marked
@Threadsafe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 587661)
Time Spent: 1h (was: 50m)
> DirectStreamObserver is not thread-safe as advertised due to racy integer
> operations
> ------------------------------------------------------------------------------------
>
> Key: BEAM-12209
> URL: https://issues.apache.org/jira/browse/BEAM-12209
> Project: Beam
> Issue Type: Bug
> Components: java-fn-execution
> Reporter: Sam Whittle
> Assignee: Sam Whittle
> Priority: P2
> Time Spent: 1h
> Remaining Estimate: 0h
>
> An AtomicInteger should be used instead for the message counting for periodic
> flow control checking.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
