[
https://issues.apache.org/jira/browse/BEAM-6720?focusedWorklogId=201707&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-201707
]
ASF GitHub Bot logged work on BEAM-6720:
----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Feb/19 01:07
Start Date: 21/Feb/19 01:07
Worklog Time Spent: 10m
Work Description: aaltay commented on issue #7911: [BEAM-6720] Add binary
compatibility adapters for ProcessFunction/InferableFunction overloads
URL: https://github.com/apache/beam/pull/7911#issuecomment-465815162
There is a compiler warning failing the build: (on Java PreCommit)
15:06:33 > Task :beam-sdks-java-extensions-euphoria:compileJava FAILED
15:06:33
/home/jenkins/jenkins-slave/workspace/beam_PreCommit_Java_Commit/src/sdks/java/extensions/euphoria/src/main/java/org/apache/beam/sdk/extensions/euphoria/core/translate/ReduceByKeyTranslator.java:69:
warning: [deprecation] <InputT,OutputT>via(SimpleFunction<InputT,OutputT>) in
MapElements has been deprecated
15:06:33 MapElements.via(new KeyValueExtractor<>(keyExtractor,
valueExtractor));
15:06:33 ^
15:06:33 where InputT,OutputT are type-variables:
15:06:33 InputT extends Object declared in method
<InputT,OutputT>via(SimpleFunction<InputT,OutputT>)
15:06:33 OutputT extends Object declared in method
<InputT,OutputT>via(SimpleFunction<InputT,OutputT>)
15:06:33 error: warnings found and -Werror specified
15:06:33 1 error
15:06:33 1 warning
Is this because the Deprecated annotation?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 201707)
Time Spent: 1h 20m (was: 1h 10m)
> Binary incompatibility introduced to MapElements between 2.9.0 and 2.10.0
> -------------------------------------------------------------------------
>
> Key: BEAM-6720
> URL: https://issues.apache.org/jira/browse/BEAM-6720
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Affects Versions: 2.10.0
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Priority: Blocker
> Fix For: 2.11.0
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> In https://github.com/apache/beam/pull/7160
> {{MapElements.via(SimpleFunction)}} was removed and replaced with
> {{MapElements.via(InferableFunction)}}.
> This is compatible with a recompile, but loses binary compatibility because
> the needed method signature is missing. I believe a pass-through method with
> the needed signature can be added to restore binary compatibility.
> CC [~jeff.klu...@gmail.com] [~altay]
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
