[ 
https://issues.apache.org/jira/browse/BEAM-12324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17343623#comment-17343623
 ] 

Yifan Mai commented on BEAM-12324:
----------------------------------

For the record, the resolution was that 
core.CombineGlobally(combiners.Largest(1)) just doesn't work in Dataflow 
streaming for some reason; [~heejong] submitted a couple of PRs replacing this 
with combiners.Top.Largest which does work. This doesn't seem to be related to 
combiner packing.

> TranslationsTest.test_run_packable_combine_* failing on 
> PostCommit_Py_VR_Dataflow
> ---------------------------------------------------------------------------------
>
>                 Key: BEAM-12324
>                 URL: https://issues.apache.org/jira/browse/BEAM-12324
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-dataflow, sdk-py-core
>            Reporter: Brian Hulette
>            Assignee: Yifan Mai
>            Priority: P1
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> Failing tests:
> - 
> apache_beam.runners.portability.fn_api_runner.translations_test.TranslationsTest.test_run_packable_combine_globally
> - 
> apache_beam.runners.portability.fn_api_runner.translations_test.TranslationsTest.test_run_packable_combine_per_key
> First failure: 
> https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/7899/
> However note that this suite was timing out since ~April 23 (BEAM-12250), so 
> the breakage could have been introduced a while ago.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to