[
https://issues.apache.org/jira/browse/BEAM-5995?focusedWorklogId=204205&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-204205
]
ASF GitHub Bot logged work on BEAM-5995:
----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Feb/19 12:00
Start Date: 26/Feb/19 12:00
Worklog Time Spent: 10m
Work Description: lgajowy commented on pull request #7808: [BEAM-5995]
Created Jenkins DSL for Python Load Tests
URL: https://github.com/apache/beam/pull/7808#discussion_r260241797
##########
File path: .test-infra/jenkins/CommonTestProperties.groovy
##########
@@ -21,7 +21,10 @@ class CommonTestProperties {
DATAFLOW("DataflowRunner", ":beam-runners-google-cloud-dataflow-java"),
SPARK("SparkRunner", ":beam-runners-spark"),
FLINK("TestFlinkRunner", ":beam-runners-flink_2.11"),
- DIRECT("DirectRunner", ":beam-runners-direct-java")
+ DIRECT("DirectRunner", ":beam-runners-direct-java"),
+
+ DATAFLOW_PYTHON("DataflowRunner", "TestDataflowRunner"),
Review comment:
We could divide an `SDK` enum and decide which dependency to choose based on
it. This would have the advantage of keeping the original "Runner" semantics
(no special cases for Python SDK). Seems like a low hanging fruit - do you
think you could refactor this (of course if you agree with the approach)?
If for some reason this will be hard - let's do it in a separate PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 204205)
Time Spent: 5h (was: 4h 50m)
> Create Jenkins jobs to run the load tests
> -----------------------------------------
>
> Key: BEAM-5995
> URL: https://issues.apache.org/jira/browse/BEAM-5995
> Project: Beam
> Issue Type: Sub-task
> Components: testing
> Reporter: Kasia Kucharczyk
> Assignee: Kasia Kucharczyk
> Priority: Major
> Labels: triaged
> Time Spent: 5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
