[ 
https://issues.apache.org/jira/browse/BEAM-5530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17362731#comment-17362731
 ] 

Anant Damle commented on BEAM-5530:
-----------------------------------

There are now some side-effects especially across different OSes: Joda daysDiff
{code:java}
@Test
public void jodaDaysDiff() {
  var days = org.joda.time.Days.daysBetween(org.joda.time.Instant.EPOCH, 
org.joda.time.Instant.parse("2002-07-13")).getDays();

  // Linux: pass
  // MacOS: fail // actual = 11881
  assertThat(days).isEqualTo(11880);
}

@Test
public void javaTimeDaysDiff() {
  var date = java.time.Instant.parse("2002-07-13T00:00:00Z");
  var days = 
java.time.temporal.ChronoUnit.DAYS.between(java.time.Instant.EPOCH, date);

  // Linux: pass
  // MacOS: pass
  assertThat(days).isEqualTo(11881);
}
{code}

> Migrate to java.time lib instead of joda-time
> ---------------------------------------------
>
>                 Key: BEAM-5530
>                 URL: https://issues.apache.org/jira/browse/BEAM-5530
>             Project: Beam
>          Issue Type: Improvement
>          Components: dependencies, sdk-java-core
>            Reporter: Alexey Romanenko
>            Priority: P3
>              Labels: Clarified
>             Fix For: 3.0.0
>
>
> Joda-time has been used till moving to Java 8. For now, these two time 
> libraries are used together. It will make sense finally to move everywhere to 
> only one lib - *java.time* - as a standard Java time library (see mail list 
> discussion: 
> [https://lists.apache.org/thread.html/b10f6f9daed44f5fa65e315a44b68b2f57c3e80225f5d549b84918af@%3Cdev.beam.apache.org%3E]).
>  
> Since this migration will introduce breaking API changes, then we should 
> address it to 3.0 release.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to