[ https://issues.apache.org/jira/browse/BEAM-6725?focusedWorklogId=206139&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-206139 ]
ASF GitHub Bot logged work on BEAM-6725: ---------------------------------------- Author: ASF GitHub Bot Created on: 28/Feb/19 23:35 Start Date: 28/Feb/19 23:35 Worklog Time Spent: 10m Work Description: ibzib commented on issue #7941: [BEAM-6725] share some Flink job invocation code with Samza runner URL: https://github.com/apache/beam/pull/7941#issuecomment-468482863 Run Python PreCommit ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 206139) Time Spent: 4h (was: 3h 50m) > Move runner-agnostic code out of FlinkJobInvocation > --------------------------------------------------- > > Key: BEAM-6725 > URL: https://issues.apache.org/jira/browse/BEAM-6725 > Project: Beam > Issue Type: Task > Components: runner-flink, runner-samza, runner-spark > Reporter: Kyle Weaver > Assignee: Kyle Weaver > Priority: Major > Labels: portability > Time Spent: 4h > Remaining Estimate: 0h > > Like BEAM-6714, FlinkJobInvocation contains some code (for asynchronously > running jobs) that isn't really Flink specific and therefore could/should be > reused by other portable runners. I'm thinking instead of an interface, > JobInvocation should be made an abstract class that implements the methods > that it currently abstracts, with an abstract method `runPipeline` for the > runner-specific details. -- This message was sent by Atlassian JIRA (v7.6.3#76005)