[
https://issues.apache.org/jira/browse/BEAM-12422?focusedWorklogId=617717&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-617717
]
ASF GitHub Bot logged work on BEAM-12422:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Jul/21 17:33
Start Date: 01/Jul/21 17:33
Worklog Time Spent: 10m
Work Description: lukecwik commented on a change in pull request #15098:
URL: https://github.com/apache/beam/pull/15098#discussion_r662474738
##########
File path:
buildSrc/src/main/groovy/org/apache/beam/gradle/GrpcVendoring_1_36_0.groovy
##########
@@ -70,7 +70,6 @@ class GrpcVendoring_1_36_0 {
return [
'com.google.errorprone:error_prone_annotations:2.4.0',
'commons-logging:commons-logging:1.2',
- 'org.apache.logging.log4j:log4j-api:2.6.2',
Review comment:
I don't think this is what we wanted to do.
The idea has always been to have the vendored libraries expose some runtime
deps as not everything should be relocated (e.g. logging shouldn't be relocated
otherwise we lose logging from the relocated code). We should have just bumped
the version to something that doesn't have the security issue and is compatible
with the 2.6.2 version.
Ditto on the exclusions, we specifically keep them to prevent relocating
logging stuff and other libs that can't be relocated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 617717)
Time Spent: 7.5h (was: 7h 20m)
> Vendored gRPC 1.36.0 is using a log4j version with security issues
> ------------------------------------------------------------------
>
> Key: BEAM-12422
> URL: https://issues.apache.org/jira/browse/BEAM-12422
> Project: Beam
> Issue Type: Bug
> Components: build-system
> Affects Versions: 2.30.0
> Reporter: Ismaël Mejía
> Assignee: Tomo Suzuki
> Priority: P1
> Time Spent: 7.5h
> Remaining Estimate: 0h
>
> Automatic security scanners report this vulnerability
> [https://nvd.nist.gov/vuln/detail/CVE-2017-5645]
> This is defined during vendoring here
> https://github.com/apache/beam/blob/3c9807bfb4e00a8f8564b4688e01ad5c8c2189d2/buildSrc/src/main/groovy/org/apache/beam/gradle/GrpcVendoring_1_36_0.groovy#L71
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
