[
https://issues.apache.org/jira/browse/BEAM-12464?focusedWorklogId=623388&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-623388
]
ASF GitHub Bot logged work on BEAM-12464:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 16/Jul/21 03:42
Start Date: 16/Jul/21 03:42
Worklog Time Spent: 10m
Work Description: aaltay commented on pull request #14974:
URL: https://github.com/apache/beam/pull/14974#issuecomment-881153538
> > Folks, what do we what do next? Does this require additional discussions?
>
> I still believe this change to be worthwhile, considering that currently
not all beam schemas containing unions can be converted to protobuf. What would
be useful to know whether or not anyone foresees issues arising from this
change of behaviour/ anything needs to be added or changed. It'd be useful to
get some feedback.
You could either add more reviewers or ask for additional comments on the
dev@ list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 623388)
Time Spent: 1h 40m (was: 1.5h)
> Change ProtoSchemaTranslator beam schema creation to match the order for
> protobufs containing Oneof fields
> ----------------------------------------------------------------------------------------------------------
>
> Key: BEAM-12464
> URL: https://issues.apache.org/jira/browse/BEAM-12464
> Project: Beam
> Issue Type: Improvement
> Components: extensions-java-protobuf
> Reporter: Reuben van Ammers
> Priority: P2
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> Currently, when ProtoSchemaTranslator creates the beam schema from a protobuf
> definition it always puts the Oneofs at the start of the beam schema due to
> Oneofs being created from the code first. This means that the order of the
> fields doesn't match the order of the protobuf defintion. As the schema
> generation is used when converting from beam rows to protobufs, it
> additionally means that it is impossible to convert from a beam row where the
> oneof fields are not the first fields in the beamrow.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
