[
https://issues.apache.org/jira/browse/BEAM-12506?focusedWorklogId=628786&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-628786
]
ASF GitHub Bot logged work on BEAM-12506:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Jul/21 23:21
Start Date: 27/Jul/21 23:21
Worklog Time Spent: 10m
Work Description: rohdesamuel commented on pull request #15217:
URL: https://github.com/apache/beam/pull/15217#issuecomment-887897296
Looks good at a glance, just wondering about the performance. By turning the
WindowedValueHolder into a Row coder, how does this impact performance? I'm
assuming that the performance increases. Subjectively, do you see a difference?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 628786)
Time Spent: 1h 50m (was: 1h 40m)
> Change WindowedValueHolder into a Row Schema
> --------------------------------------------
>
> Key: BEAM-12506
> URL: https://issues.apache.org/jira/browse/BEAM-12506
> Project: Beam
> Issue Type: Improvement
> Components: runner-py-interactive
> Reporter: Ning
> Assignee: Ning
> Priority: P2
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> The WindowedValueHolder is a Python type that requires a special
> `SafeFastPrimitivesCoder` instead of the native `FastPrimitivesCoder` in
> cache_manager to encode and decode.
> When reading cache of it and applying an external transform such as a
> SqlTransform, it introduces a pickled Python coder that is not xLang friendly.
> We could build a Row schema to hold the WindowedValueHolder to make the cache
> reading xLang friendly and also get rid of the additional layer of
> `SafeFastPrimitivesCoder`.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
