[
https://issues.apache.org/jira/browse/BEAM-3279?focusedWorklogId=213819&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-213819
]
ASF GitHub Bot logged work on BEAM-3279:
----------------------------------------
Author: ASF GitHub Bot
Created on: 15/Mar/19 15:10
Start Date: 15/Mar/19 15:10
Worklog Time Spent: 10m
Work Description: AlexKbit commented on pull request #8071: [BEAM-3279]
Deprecate and remove Coder.consistentWithEquals
URL: https://github.com/apache/beam/pull/8071
Hi @kennknowles !
Could you please review my changes:
1) Deprecate Coder.consistentWithEquals method and add javadoc
2) Remove overriding from coders in the java-core
I'm not sure about removal of overriding from :
org.apache.beam.sdk.coders.MapCoder#consistentWithEquals
org.apache.beam.sdk.coders.ListCoder#consistentWithEquals
because it breaks the tests below:
org.apache.beam.sdk.coders.MapCoderTest > testConsistentWithEquals FAILED
org.apache.beam.sdk.coders.ListCoderTest > testConsistentWithEquals FAILED
I can rewrite these tests if it's necessary.
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/)
| --- | --- | --- | --- | --- | ---
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python3_Verify/lastCompletedBuild/)
| --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)
<br> [](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PreCommit_Python_PVR_Flink_Cron/lastCompletedBuild/)
| --- | --- | ---
See
[.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md)
for trigger phrase, status and link of all Jenkins jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 213819)
Time Spent: 10m
Remaining Estimate: 0h
> Deprecate and remove Coder consistentWithEquals in favor of overriding
> structuredValue
> --------------------------------------------------------------------------------------
>
> Key: BEAM-3279
> URL: https://issues.apache.org/jira/browse/BEAM-3279
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Kenneth Knowles
> Assignee: Alexander Savchenko
> Priority: Minor
> Labels: starter
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Summary of discussion linked below:
> consistentWithEquals() is redundant w.r.t. structuralValue(), and should be
> deprecated. I think our mutation detectors are already using
> structuralValue(), so the work here would be to simply mark the method
> deprecated, remove all remaining overrides in the SDK, and document that
> overriding the method is a no-op.
> https://lists.apache.org/thread.html/8b2dcf09ba8e46b3c008293d99e4028d10463148b68326687dc29a4d@%3Cdev.beam.apache.org%3E
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
