[
https://issues.apache.org/jira/browse/BEAM-6778?focusedWorklogId=214632&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-214632
]
ASF GitHub Bot logged work on BEAM-6778:
----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Mar/19 08:03
Start Date: 18/Mar/19 08:03
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #7937: [BEAM-6778]
Enable Bundle Finalization in Python SDK harness over FnApi
URL: https://github.com/apache/beam/pull/7937#discussion_r266326172
##########
File path: sdks/python/apache_beam/runners/worker/sdk_worker.py
##########
@@ -186,11 +186,11 @@ def task():
try:
self._execute(lambda: worker.do_instruction(work), work)
finally:
- # Delete the instruction_id <-> worker mapping
- self._instruction_id_vs_worker.pop(work.instruction_id, None)
- # Put the worker back in the free worker pool
- self.workers.put(worker)
-
+ if not worker.has_active_processors():
Review comment:
Yes, this is great.
The only issue is that there is a limited number of workers, and we don't
want to use them up (or wait for them) for progress/split calls. Given that
these worker are stateless and threadsafe, perhaps a reasonable solution would
be to create one extra worker that we always use for progress and split (but
not for process or bundle finalization).
Other than that, looks good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 214632)
Time Spent: 4h 40m (was: 4.5h)
> Enable Bundle Finalization in Python SDK
> ----------------------------------------
>
> Key: BEAM-6778
> URL: https://issues.apache.org/jira/browse/BEAM-6778
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-harness
> Reporter: Boyuan Zhang
> Assignee: Boyuan Zhang
> Priority: Major
> Time Spent: 4h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
