[
https://issues.apache.org/jira/browse/BEAM-6778?focusedWorklogId=215918&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-215918
]
ASF GitHub Bot logged work on BEAM-6778:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Mar/19 00:46
Start Date: 20/Mar/19 00:46
Worklog Time Spent: 10m
Work Description: boyuanzz commented on pull request #7937: [BEAM-6778]
Enable Bundle Finalization in Python SDK harness over FnApi
URL: https://github.com/apache/beam/pull/7937#discussion_r267151135
##########
File path: sdks/python/apache_beam/runners/worker/sdk_worker.py
##########
@@ -313,15 +314,18 @@ def process_bundle(self, request, instruction_id):
with bundle_processor.state_handler.process_instruction_id(
instruction_id):
with self.maybe_profile(instruction_id):
- delayed_applications =
bundle_processor.process_bundle(instruction_id)
+ delayed_applications, requests_finalization = (
+ bundle_processor.process_bundle(instruction_id))
response = beam_fn_api_pb2.InstructionResponse(
instruction_id=instruction_id,
process_bundle=beam_fn_api_pb2.ProcessBundleResponse(
residual_roots=delayed_applications,
metrics=bundle_processor.metrics(),
- monitoring_infos=bundle_processor.monitoring_infos()))
- # TODO(boyuanz): Don't release here if finalize is needed.
- self.bundle_processor_cache.release(instruction_id)
+ monitoring_infos=bundle_processor.monitoring_infos(),
+ requires_finalization=requests_finalization))
+ # Don't release here if finalize is needed.
+ if not bundle_processor.requires_finalization():
Review comment:
fixed here:
https://github.com/apache/beam/pull/7937/commits/03e168102db43873e1170804df4e5f3afe6d0e8d
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 215918)
Time Spent: 8h 50m (was: 8h 40m)
> Enable Bundle Finalization in Python SDK
> ----------------------------------------
>
> Key: BEAM-6778
> URL: https://issues.apache.org/jira/browse/BEAM-6778
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-harness
> Reporter: Boyuan Zhang
> Assignee: Boyuan Zhang
> Priority: Major
> Time Spent: 8h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
