[ https://issues.apache.org/jira/browse/BEAM-6861?focusedWorklogId=216085&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-216085 ]
ASF GitHub Bot logged work on BEAM-6861: ---------------------------------------- Author: ASF GitHub Bot Created on: 20/Mar/19 09:59 Start Date: 20/Mar/19 09:59 Worklog Time Spent: 10m Work Description: stankiewicz commented on pull request #8090: [BEAM-6861] Select fields and computed fields in CassandraIO.Read URL: https://github.com/apache/beam/pull/8090#discussion_r267260062 ########## File path: sdks/java/io/cassandra/src/main/java/org/apache/beam/sdk/io/cassandra/CassandraIO.java ########## @@ -483,6 +508,11 @@ private CassandraIO() {} .collect(Collectors.joining(",")); List<BoundedSource<T>> sources = new ArrayList<>(); + String selectFields = "*"; + if (spec.selectFields() != null) { + selectFields = String.join(",", spec.selectFields().get()); Review comment: @iemejia , thanks for feedback - challenge with withQuery in JdbcIO is that it is expected to be full query, like `select a from b` or `select a from b where c='d'`. In CassandraIO select is generated so it can be split based on key ranges so 'where' part is partially dynamic so where part is set via separate field and I want select fields also set via seperate field/list of fields. That's why external builder can be challenge to support every case, unless it gives placeholder for each of those (select fields, where fields). So I generally agree we need some more generic but I don't think I could generalize mentioned MongoDB (BEAM-6241) and Cassandra query builder because they are totally different but definately I could try to create such builder for Cassandra that will gather projection/select fields and filter ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 216085) Time Spent: 1h 40m (was: 1.5h) > Select fields and computed fields in CassandraIO.Read > ------------------------------------------------------ > > Key: BEAM-6861 > URL: https://issues.apache.org/jira/browse/BEAM-6861 > Project: Beam > Issue Type: Improvement > Components: io-java-cassandra > Reporter: Radosław Stankiewicz > Assignee: Radosław Stankiewicz > Priority: Minor > Labels: features > Time Spent: 1h 40m > Remaining Estimate: 0h > > CassandraIO.Read currently selects all fields and maps them to POJO. > To make this component more flexible, it should be possible to select only > subset of fields or computed fields to allow reading things like write > Timestamp or using other functions. -- This message was sent by Atlassian JIRA (v7.6.3#76005)