[
https://issues.apache.org/jira/browse/BEAM-6619?focusedWorklogId=216378&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-216378
]
ASF GitHub Bot logged work on BEAM-6619:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Mar/19 18:14
Start Date: 20/Mar/19 18:14
Worklog Time Spent: 10m
Work Description: tvalentyn commented on pull request #8076: [BEAM-6619]
[BEAM-6593] Add bigquery integration tests to postcommit
URL: https://github.com/apache/beam/pull/8076#discussion_r267479836
##########
File path:
sdks/python/apache_beam/examples/complete/game/leader_board_it_test.py
##########
@@ -53,7 +53,7 @@
class LeaderBoardIT(unittest.TestCase):
# Input event containing user, team, score, processing time, window start.
- INPUT_EVENT = 'user1,teamA,10,%d,2015-11-02 09:09:28.224'
+ INPUT_EVENT = b'user1,teamA,10,%d,2015-11-02 09:09:28.224'
Review comment:
So the question is then, to the humans who read and edit this code, should
INPUT_EVENT be a textual date or encoded data? I think it's easier to consider
it text, up until it's time to feed it to pubsub, then when we can encode it to
bytes.
I'd keep INPUT_EVENT as is change publishing to:
```
event = self.INPUT_EVENT % self._test_timestamp
self.pub_client.publish(event.encode('utf-8'))
```
I would expect users to follow a similar pattern in their pipelines, and
they might refer to beam examples for guidance, so I suggest to change this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 216378)
Time Spent: 20h 50m (was: 20h 40m)
> Add PostCommit suite for integration tests on DataflowRunner
> ------------------------------------------------------------
>
> Key: BEAM-6619
> URL: https://issues.apache.org/jira/browse/BEAM-6619
> Project: Beam
> Issue Type: Sub-task
> Components: testing
> Reporter: Mark Liu
> Assignee: Mark Liu
> Priority: Major
> Labels: triaged
> Fix For: Not applicable
>
> Time Spent: 20h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
