[
https://issues.apache.org/jira/browse/BEAM-6838?focusedWorklogId=216555&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-216555
]
ASF GitHub Bot logged work on BEAM-6838:
----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Mar/19 00:16
Start Date: 21/Mar/19 00:16
Worklog Time Spent: 10m
Work Description: youngoli commented on issue #8064: [BEAM-6838] Go SDK:
Improving error msgs in pipeline serialization.
URL: https://github.com/apache/beam/pull/8064#issuecomment-475076149
There definitely is a lot of repetition with the recursion, even before my
changes. Though I'm not sure how to avoid that really. While it's a lot of
information for users, it's important for debugging. Only alternative I can
think of is adding some debug logs instead of some errors, so users can see the
path being taken by examining logs.
Here's a real-world example I've been using to test (I replaced the proto
name though)
> failed to encode custom coder: bad underlying type: bad element: bad field
type: bad element: bad element: bad field type: bad element: bad field type:
bad element: bad element: bad field type: bad field type: bad element: bad
field type: unencodable type: protoapi.extensionMap
And the new error:
> Failed to encode custom coder for type protoapi.Message. Make sure the
type was registered before calling beam.Init. For example:
beam.RegisterType(reflect.TypeOf((*TypeName)(nil)).Elem())
>
> Full error: failed to encode custom coder
*my_package.MyProto[protoapi.Message], bad underlying type: failed to encode
pointer *my_package.MyProto, bad base type: failed to encode struct
my_package.MyProto, bad field type: failed to encode pointer
*my_package.MyProto_MyField, bad base type: failed to encode struct
my_package.MyProto_MyField, bad field type: unencodable type
map[int32]protoapi.Message
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 216555)
Time Spent: 7h 20m (was: 7h 10m)
> Improve error messages for unregistered protos
> ----------------------------------------------
>
> Key: BEAM-6838
> URL: https://issues.apache.org/jira/browse/BEAM-6838
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-go
> Reporter: Daniel Oliveira
> Assignee: Daniel Oliveira
> Priority: Minor
> Time Spent: 7h 20m
> Remaining Estimate: 0h
>
> When users have a type that can't be serialized (it has a function Field or
> similar) or more complex protocol buffers, the error should be improved to
> display the type being registered, and better yet, the beam.RegisterType(...)
> code they can use to enable use of their type.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
