[
https://issues.apache.org/jira/browse/BEAM-6772?focusedWorklogId=216907&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-216907
]
ASF GitHub Bot logged work on BEAM-6772:
----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Mar/19 18:08
Start Date: 21/Mar/19 18:08
Worklog Time Spent: 10m
Work Description: kanterov commented on pull request #8006: [BEAM-6772]
Change Select semantics to match what a user expects
URL: https://github.com/apache/beam/pull/8006#discussion_r267873121
##########
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/utils/SelectHelpers.java
##########
@@ -106,47 +164,89 @@ public static Row selectRow(
}
Row.Builder output = Row.withSchema(outputSchema);
+ selectIntoRow(input, output, fieldAccessDescriptor, inputSchema);
+ return output.build();
+ }
+
+ /** Select out of a given {@link Row} object. */
+ public static void selectIntoRow(
+ Row input,
+ Row.Builder output,
+ FieldAccessDescriptor fieldAccessDescriptor,
+ Schema inputSchema) {
Review comment:
Is it the same as `input.getSchema()`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 216907)
Time Spent: 5h 50m (was: 5h 40m)
> Select transform has non-intuitive semantics
> --------------------------------------------
>
> Key: BEAM-6772
> URL: https://issues.apache.org/jira/browse/BEAM-6772
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-java-core
> Reporter: Reuven Lax
> Assignee: Reuven Lax
> Priority: Major
> Time Spent: 5h 50m
> Remaining Estimate: 0h
>
> Consider the following schema:
> User:
> name: STRING
> location: Location
>
> Location:
> latitude: DOUBLE
> longitude: DOUBLE
>
> If you apply Select.fieldNames("location"), most users expect to get back a
> row matching the Location schema. Instead you get back an outer schema with a
> single location field in it. Select should instead unnest the output up to
> the point where multiple fields are selected.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
