[
https://issues.apache.org/jira/browse/BEAM-13386?focusedWorklogId=697682&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-697682
]
ASF GitHub Bot logged work on BEAM-13386:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Dec/21 02:06
Start Date: 17/Dec/21 02:06
Worklog Time Spent: 10m
Work Description: tvalentyn commented on a change in pull request #16250:
URL: https://github.com/apache/beam/pull/16250#discussion_r771046467
##########
File path: sdks/python/apache_beam/internal/cloudpickle_pickler.py
##########
@@ -99,6 +103,14 @@ def _create_absl_flags():
return flags.FLAGS
+def _pickle_rlock(obj):
+ return _create_rlock, tuple([])
+
+
+def _create_rlock():
+ return RLOCK_TYPE()
Review comment:
Should this return RLOCK_TYPE instead of RLOCK_TYPE() ?
##########
File path: sdks/python/apache_beam/internal/cloudpickle_pickler.py
##########
@@ -99,6 +103,14 @@ def _create_absl_flags():
return flags.FLAGS
+def _pickle_rlock(obj):
+ return _create_rlock, tuple([])
+
+
+def _create_rlock():
+ return RLOCK_TYPE()
Review comment:
Also, consider adding a test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@beam.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 697682)
Time Spent: 1h (was: 50m)
> Make cloudpickle the default pickle library
> -------------------------------------------
>
> Key: BEAM-13386
> URL: https://issues.apache.org/jira/browse/BEAM-13386
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: Ryan Thompson
> Assignee: Ryan Thompson
> Priority: P3
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Make cloudpickle the default pickle library.
>
> See change [https://github.com/apache/beam/pull/15472] and docs
> [_https://s.apache.org/beam-picklers_].
>
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
