[ 
https://issues.apache.org/jira/browse/BEAM-5959?focusedWorklogId=218408&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-218408
 ]

ASF GitHub Bot logged work on BEAM-5959:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 26/Mar/19 01:27
            Start Date: 26/Mar/19 01:27
    Worklog Time Spent: 10m 
      Work Description: mayansalama commented on pull request #7744: 
[BEAM-5959] KMS support for BigQuery
URL: https://github.com/apache/beam/pull/7744#discussion_r268914070
 
 

 ##########
 File path: 
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIO.java
 ##########
 @@ -1534,6 +1550,10 @@ static String getExtractDestinationUri(String 
extractDestinationDir) {
       return toBuilder().setIgnoreUnknownValues(true).build();
     }
 
+    Write<T> withKmsKey(String kmsKey) {
 
 Review comment:
   Shouldn't this method be public? 
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 218408)
    Time Spent: 30h 50m  (was: 30h 40m)

> Add Cloud KMS support to GCS copies
> -----------------------------------
>
>                 Key: BEAM-5959
>                 URL: https://issues.apache.org/jira/browse/BEAM-5959
>             Project: Beam
>          Issue Type: Bug
>          Components: io-java-gcp, sdk-py-core
>            Reporter: Udi Meiri
>            Assignee: Udi Meiri
>            Priority: Major
>              Labels: triaged
>             Fix For: 2.11.0
>
>          Time Spent: 30h 50m
>  Remaining Estimate: 0h
>
> Beam SDK currently uses the CopyTo GCS API call, which doesn't support 
> copying objects that Customer Managed Encryption Keys (CMEK).
> CMEKs are managed in Cloud KMS.
> Items (for Java and Python SDKs):
> - Update clients to versions that support KMS keys.
> - Change copyTo API calls to use rewriteTo (Python - directly, Java - 
> possibly convert copyTo API call to use client library)
> - Add unit tests.
> - Add basic tests (DirectRunner and GCS buckets with CMEK).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to